This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: use bsddb185 if necessary in dbhash
Type: Stage:
Components: Library (Lib) Versions: Python 2.3
process
Status: closed Resolution:
Dependencies: Superseder:
Assigned To: barry Nosy List: barry, loewis, skip.montanaro
Priority: normal Keywords:

Created on 2003-04-24 19:56 by skip.montanaro, last changed 2022-04-10 16:08 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
dbhash.diff skip.montanaro, 2003-04-24 19:56
Messages (5)
msg15594 - (view) Author: Skip Montanaro (skip.montanaro) * (Python triager) Date: 2003-04-24 19:56
I've had this patch sitting around for awhile.  I think if the new
bsddb stuff can't be built and the user enables the bsddb185
module in Modules/Setup that dbhash should also try that
module when setting things up.
msg15595 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2003-05-03 15:18
Logged In: YES 
user_id=21627

-1. I think users should make an explicit decision to use
bsddb 1.85, and should get an error if they use any of the
libraries on top of it.

The only reasonable exception might be whichdb, which could
say 'bsddb185', if it recognizes the file format.
msg15596 - (view) Author: Skip Montanaro (skip.montanaro) * (Python triager) Date: 2003-05-03 20:17
Logged In: YES 
user_id=44345

There are valid reasons why people don't update their db library.  The
most obvious one that occurs to me is that the system itself stores
files with that version of the library which applications need to read
(I remember the pwd module had this problem at one time.  Probably
still does under the correct circumstances.)

As for whichdb returning "bsddb185", that can only happen if we
are willing to an "open" method to it.  Even then, whichdb will
probably have to be made more discriminating (distinguishing
files readable via db 1.85 ("bsddb185") and files readable by
more recent versions ("dbhash").
msg15597 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2003-05-03 21:20
Logged In: YES 
user_id=21627

I agree that people will want to use bsddb185 to open
existing files, and we should make this readily available.
At the same, we should not  provide easy means to create new
files.

So I suggest to reject this patch: If anything is done about
dbhash, it should check, on open, what version of the
database library needs to be used to open an existing file.

It is indeed the case that the current whichdb
implementation is not capable of distinguishing BSDB on-disk
format versions. Such version information is available
inside the file, and it would be possible to teach whichdb
about that.
msg15598 - (view) Author: Skip Montanaro (skip.montanaro) * (Python triager) Date: 2003-05-05 14:17
Logged In: YES 
user_id=44345

closing in favor of bug 731501
History
Date User Action Args
2022-04-10 16:08:19adminsetgithub: 38362
2003-04-24 19:56:20skip.montanarocreate