This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test_timeout updates
Type: Stage:
Components: Tests Versions: Python 2.5
process
Status: closed Resolution:
Dependencies: Superseder: test_timeout refactoring
View: 1677694
Assigned To: Nosy List: collinwinter, doerwalter, hdima, loewis, rhettinger, sonderblade
Priority: normal Keywords: patch

Created on 2003-04-28 10:21 by hdima, last changed 2022-04-10 16:08 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
test_timeout.diff hdima, 2003-04-28 10:21 Lib/test/test_timeout.py patch
Messages (9)
msg43513 - (view) Author: Dmitry Vasiliev (hdima) Date: 2003-04-28 10:21
Changes:

- code refactoring;
- now we catch only exceptions with proper errno codes
(also see bug #708927);
- addr_remote changed, ('www.google.com', 80) not
always works for me since we use transparent proxy;
- attempt to implement testSend(), testSendto(),
testSendall();
msg43514 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2003-06-28 14:09
Logged In: YES 
user_id=80475

Walter, are you interested in working this patch?
msg43515 - (view) Author: Walter Dörwald (doerwalter) * (Python committer) Date: 2003-06-30 12:37
Logged In: YES 
user_id=89016

I'm no expert in socket programming, so the final decision
whether  this is OK is your's.
msg43516 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2003-06-30 14:52
Logged In: YES 
user_id=80475

I'll give it more review.

Since Py2.3b2 is out, I'm marking this as a change for Py2.4 
and we can apply it in early August.
msg43517 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2003-06-30 14:52
Logged In: YES 
user_id=80475

I'll give it more review.

Since Py2.3b2 is out, I'm marking this as a change for Py2.4 
and we can apply it in early August.
msg43518 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2003-06-30 14:52
Logged In: YES 
user_id=80475

I'll give it more review.

Since Py2.3b2 is out, I'm marking this as a change for Py2.4 
and we can apply it in early August.
msg43519 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2006-04-14 16:10
Logged In: YES 
user_id=21627

rhettinger: would you like to review it now? If not, please
unassign.
msg43520 - (view) Author: Björn Lindqvist (sonderblade) Date: 2007-03-10 00:52
I have created a patch that I hope can supersede this one. This patch
does some nice refactorings to test_timeout.py by encapsulating some
common code in a sockOperation method. Then that method is used to run
the function under test. It also implements tests for testSend,
testSendto and testSendall. Plus, (I think) it fixes a bug which (I
think) only happens when you access the internet from behind a web
proxy.

I think the patch is good but there were two problems with it so I
created a new one. First, it tries to filter out errors dealing with
timeouts from normal socket.error's. But the author forgot about args
with only one string as a value. Second, I do not like how the actual
assertion of the test is done in the tearDown method.

My patch fixes those problems, otherwise it is mostly identical to
this patch. It is #1677694 at http://sourceforge.net/tracker/index.php?func=detail&aid=1677694&group_id=5470&atid=105470
msg43521 - (view) Author: Collin Winter (collinwinter) * (Python committer) Date: 2007-03-28 23:41
Bjorn's patch #1677694 supersedes this one, closing.
History
Date User Action Args
2022-04-10 16:08:24adminsetgithub: 38388
2010-07-17 02:34:31belopolskysetsuperseder: test_timeout refactoring
2009-03-30 22:36:52ajaksu2linkissue1677694 dependencies
2003-04-28 10:21:58hdimacreate