➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Compiler warning on Solaris 8
Type: Stage:
Components: Build Versions: Python 2.2
process
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: nnorwitz Nosy List: gnn, loewis, nnorwitz, rhettinger
Priority: normal Keywords: patch

Created on 2003-04-29 02:42 by gnn, last changed 2022-04-10 16:08 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
configure.in.patch gnn, 2003-04-29 02:42
Messages (6)
msg43529 - (view) Author: George Neville-Neil (gnn) Date: 2003-04-29 02:42 
When compiling Python 2.2 on Solaris 8 there are complaints about _FILE_OFFSET_BITS being redefined.

The following is a patch to configure.in to remedy this.
msg43530 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2003-04-29 04:47 
Logged In: YES 
user_id=80475

Neal, is this something you know about?
msg43531 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2003-04-29 11:47 
Logged In: YES 
user_id=21627

The patch is clearly incorrect; Python *must* define 
_FILE_OFFSET_BITS. What specific problem does that 
patch fix?
msg43532 - (view) Author: George Neville-Neil (gnn) Date: 2003-05-02 23:12 
Logged In: YES 
user_id=767347

The point of the patch is that on Solaris 8 there is a file that already defines this and if configure does not notice this then
both pyconfig.h and the OS file sys/feature_test.h define it and 
when building a program with Python embedded in it you get a
lot of warnings.
msg43533 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2003-05-02 23:57 
Logged In: YES 
user_id=21627

Your observation is incorrect: sys/feature_tests.h does
*not* unconditionally define _FILE_OFFSET_BITS. Instead, it
reads

#if defined(_LP64)
#ifndef _FILE_OFFSET_BITS
#define _FILE_OFFSET_BITS       64
#endif
#if     _FILE_OFFSET_BITS - 0 != 64
#error  "invalid _FILE_OFFSET_BITS value specified"
#endif
#else   /* _LP64 */
#ifndef _FILE_OFFSET_BITS
#define _FILE_OFFSET_BITS       32
#endif
#if     _FILE_OFFSET_BITS - 0 != 32 && _FILE_OFFSET_BITS - 0
!= 64
#error  "invalid _FILE_OFFSET_BITS value specified"
#endif
#endif  /* _LP64 */

So _FILE_OFFSET_BITS is always defined conditionally only,
on the condition that it isn't already defined. Since
Python.h is included before anything else, feature_tests.h
does *not* define it, ever.
msg43534 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2003-06-06 22:28 
Logged In: YES 
user_id=21627

Rejecting the patch: There is no bug that it fixes.
History
Date User Action Args
2022-04-10 16:08:26adminsetgithub: 38395
2003-04-29 02:42:35gnncreate