➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2003-07-23 12:02 by jackjansen, last changed 2022-04-10 16:10 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| test_uu_log.txt | jackjansen, 2003-08-04 11:41 | Output of test_uu | ||
| diff.txt | doerwalter, 2003-08-04 13:33 | Using text mode everywhere | ||
| Messages (9) | |||
|---|---|---|---|
| msg17289 - (view) | Author: Jack Jansen (jackjansen) *  |
Date: 2003-07-23 12:02 | |
test_uu fails on MacPython-OS9: AssertionError: 'The smooth-scaled python crept over the sleeping dog\r' != 'The smooth-scaled python crept over the sleeping dog\n' Presumably it mixes binary and text I/O. |
|||
| msg17290 - (view) | Author: Jack Jansen (jackjansen) * |
Date: 2003-07-31 19:50 | |
Logged In: YES user_id=45365 I changed the open call to use 'rU' in stead of 'r' (test_uu rev. 1.6.6.1). I get the distinct impression that this isn't the right fix, though, but that the real problem is elsewhere (mixing up text and binary I/O), so I'd like a second opinion. |
|||
| msg17291 - (view) | Author: Walter Dörwald (doerwalter) * |
Date: 2003-08-04 11:21 | |
Logged In: YES user_id=89016 It would help to see a complete traceback (Is the error in test_encode or test_decode?) |
|||
| msg17292 - (view) | Author: Jack Jansen (jackjansen) * |
Date: 2003-08-04 11:41 | |
Logged In: YES user_id=45365 It's in test_decode. The log is attached. |
|||
| msg17293 - (view) | Author: Walter Dörwald (doerwalter) * |
Date: 2003-08-04 13:33 | |
Logged In: YES user_id=89016 Can you try the following patch (diff.txt)? The patch changes all open() statements to use text mode. I've tested the patch on Windows and Linux. I don't know why the old test mixed text and binary mode. The test should have failed even before the port to PyUnit. |
|||
| msg17294 - (view) | Author: A.M. Kuchling (akuchling) * |
Date: 2006-12-22 13:33 | |
Should the suggested patch be applied, simply for the sake of consistency in test_uu? It's probably difficult to replicate this bug now; does Jack even have a MacOS 9 installation any more? |
|||
| msg17295 - (view) | Author: Jack Jansen (jackjansen) * |
Date: 2006-12-22 15:46 | |
MacOS9 is long dead, uuencoded files are probably even longer dead... If the patch looks good: apply it. But I wouldn't spend more than a few milliseconds on the whole issue:-) |
|||
| msg17296 - (view) | Author: A.M. Kuchling (akuchling) * |
Date: 2006-12-22 16:43 | |
Applied in rev. 53145. |
|||
| msg17297 - (view) | Author: Neal Norwitz (nnorwitz) * |
Date: 2007-01-18 06:17 | |
r53481 partially reverted the changes that were failing on Windows. test_encode (test.test_uu.UUFileTest) ... FAIL |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-10 16:10:10 | admin | set | github: 38914 |
| 2003-07-23 12:02:12 | jackjansen | create | |