This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: POP3 over SSL support for poplib
Type: Stage:
Components: Library (Lib) Versions: Python 2.3
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: loewis Nosy List: loewis, mrbook
Priority: normal Keywords: patch

Created on 2003-08-20 05:53 by mrbook, last changed 2022-04-10 16:10 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
poplib.patch mrbook, 2003-08-20 05:53 patch for poplib.py which adds SSL support
lipoplibdoc-1_0.patch mrbook, 2003-09-11 01:05 patch for libpoplib.tex
poplibssl-1_0.patch mrbook, 2003-09-11 01:06 patch for poplib.py which adds SSL support
Messages (4)
msg44479 - (view) Author: Hector urtubia (mrbook) Date: 2003-08-20 05:53
This patch creates a class POP3_SSL which is a child of
POP3 on the poplib module.
This class is able to handle POP3 over SSL. It borrows
some code from IMAP_SSL.
msg44480 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2003-08-31 16:38
Logged In: YES 
user_id=21627

Can you please provide a patch for the documentation as well?

Please don't mix tabs and spaces; I recommend to run
reindent.py before producing the diff.

In the class comment, the default port is incorrect.

Please don't build up strings by adding one character at a
time, use [c]StringIO instead, or a list. Also consider
reading larger chunks of data a time, buffering extra data
in the class.

Try to reuse the base-class __init__.
msg44481 - (view) Author: Hector urtubia (mrbook) Date: 2003-09-11 01:11
Logged In: YES 
user_id=10927

I have added a patch for the documentation (lipoplibdoc-
1_0.patch) and have addressed most of the requests from 
the reviewer on newer patch revision (poplibssl-1_0.patch).

- Tabs and spaces issues fixed
- Fixed port on comment
- Data is now read on big chunks
- Unable to reuse base-claass __init__ because of parent's 
design issues.

Cheers.
msg44482 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2003-10-31 12:53
Logged In: YES 
user_id=21627

Thanks for the patch. Applied as 

libpoplib.tex 1.16
poplib.py 1.22
ACKS 1.252
NEWS 1.882
History
Date User Action Args
2022-04-10 16:10:44adminsetgithub: 39093
2003-08-20 05:53:45mrbookcreate