Logged In: YES
user_id=29957
The following patch gives us a urllib2 that supports digest
auth again. I've tested against Apache-2..0.47, if someone
wants to suggest another webserver to check with, please let
me know.
We now support RFC2617-compliant versions of digest auth. I
have no idea what the code that was in there was trying to
do, but it was broken all over the place - there is no way
it would have worked.
Note the following limitations:
- We are sending a client nonce, but we're not checking the
Authentication-Info that's coming back.
- qop="auth-int" support is shaky. But apache looks like it
doesn't support it properly, anyway. And it's no shakier
than it was <wink>
- algorithm="MD5-sess" isn't properly supported, but then,
it wasn't before, either.
- the code now has a limit of 5 failures in a row before it
bails out . there was no limit previously, so it would
recurse until the recursion limit was hit.
I can't test the old code, unfortunately, but I _believe_
I've made it work again. It certainly could not have worked
as it was. I've also not tested proxy-digest-auth -
suggestions for a proxy server to try? Assuming my reading
of the RFC is right, it should "just work".
|