➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2003-11-21 15:53 by lars.gustaebel, last changed 2022-04-11 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| bugfix-812325-and-tests.patch | lars.gustaebel, 2004-02-25 19:12 | complete patchset including fixes and tests | ||
| Messages (7) | |||
|---|---|---|---|
| msg44913 - (view) | Author: Lars Gustäbel (lars.gustaebel) *  |
Date: 2003-11-21 15:53 | |
The attached patch fixes an error in the code for GNU longname/longlink creation. An additional GNU header block is added to the tar file but not summed up to the internal counter (self.offset). On close() the zeropadding is miscalculated which leads to blocksize violation at the end of the archive. I had a conversation with Johan Fredrik Öhman (johanfo) who reported bug #812325 and he told me that my patch solved his problems. |
|||
| msg44914 - (view) | Author: Neal Norwitz (nnorwitz) * |
Date: 2003-12-14 15:14 | |
Logged In: YES user_id=33168 Lars, could you add a test case for this as well? |
|||
| msg44915 - (view) | Author: Lars Gustäbel (lars.gustaebel) * |
Date: 2003-12-16 14:18 | |
Logged In: YES user_id=642936 I must admit, that longnames/longlinks haven't been covered at all by the test suite until now. Shame on me :-( So I'm working on some general testcases right now. While writing the tests, I discovered yet another bug in the longname creation code that must be fixed. Shame on me again :-(( If you agree, Neal, I will submit a second patch that eliminates this new bug and includes a complete set of test cases for both bugs. |
|||
| msg44916 - (view) | Author: Neal Norwitz (nnorwitz) * |
Date: 2003-12-22 04:35 | |
Logged In: YES user_id=33168 More tests are always good. :-) I'll try to take a look at this later, or if someone else checks in that's fine too. Also, if I don't get to this, feel free to add the tests to this patch. Thanks. |
|||
| msg44917 - (view) | Author: Lars Gustäbel (lars.gustaebel) * |
Date: 2004-02-25 19:12 | |
Logged In: YES user_id=642936 This is now the complete final patchset: - fixes bug #812325. - fixes the second bug in _create_gnulong() I discovered. - adds a testcase for GNUlong extensions. - reverses a patch by A.M. Kuchling which addresses bug #812325 but which is unnecessary. |
|||
| msg44918 - (view) | Author: Lars Gustäbel (lars.gustaebel) * |
Date: 2004-07-12 08:49 | |
Logged In: YES user_id=642936 Are there any chances to have this patch (and probably the other pending tarfile patches) applied for the next release? |
|||
| msg44919 - (view) | Author: Neal Norwitz (nnorwitz) * |
Date: 2004-07-20 21:55 | |
Logged In: YES user_id=33168 Sorry it took so long. Checking in: * Lib/tarfile.py; 1.12 * Lib/test/test_tarfile.py; 1.12 * Misc/NEWS; 1.1047 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:56:01 | admin | set | github: 39580 |
| 2003-11-21 15:53:24 | lars.gustaebel | create | |