➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Optional keyword unicode args not handled correctly
Type: Stage:
Components: Interpreter Core Versions:
process
Status: closed Resolution: out of date
Dependencies: Superseder:
Assigned To: Nosy List: georg.brandl, mdehoon, mdr0, rupole
Priority: normal Keywords: patch

Created on 2003-12-04 08:05 by rupole, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
getargs.patch rupole, 2003-12-04 08:05 patch for getargs.c
skipitem.txt rupole, 2005-03-28 22:04
Messages (5)
msg45013 - (view) Author: Roger Upole (rupole) Date: 2003-12-04 08:05 
Added a case for 'u' in skipitem in getargs.c
msg45014 - (view) Author: Mark D. Roth (mdr0) Date: 2004-07-06 04:39 
Logged In: YES 
user_id=994239

skipitem() is actually missing code for a number of other
format units, in addition to "u" and "u#".  See patch 985713
for more information.
msg45015 - (view) Author: Michiel de Hoon (mdehoon) * Date: 2005-03-27 07:20 
Logged In: YES 
user_id=488897

As mdr0 mentioned, skipitem misses code for several formats.
This patch solves one, patch 985713 solves another one.
Could you make a patch that solves all missing formats in
skipitem? You can look at the convertsimple function to find
all formats.
msg45016 - (view) Author: Roger Upole (rupole) Date: 2005-03-28 22:04 
Logged In: YES 
user_id=771074

After taking another look at this, all the arguments it 
processes are pointers.  Since they're not actually changed 
by this function, they can all be treated as void *, eliminating 
the case stmt altogether and effectively future-proofing the 
function.  With as little code as is left, and since it's only 
called from one place, inlining it might be feasible.

This leaves out validation of the format char, but I'd say it's up 
to whoever constructs the argument format to make sure it 
works correctly when you pass in a matching arg.
msg45017 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2005-06-01 18:24 
Logged In: YES 
user_id=1188172

Closing; subsumed by patch #1212928.
History
Date User Action Args
2022-04-11 14:56:01adminsetgithub: 39662
2003-12-04 08:05:17rupolecreate