This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: bdist_wininst pre-install script, and --target-version fix
Type: Stage:
Components: Distutils Versions: Python 2.4
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: theller Nosy List: mhammond, theller
Priority: normal Keywords: patch

Created on 2004-02-07 23:53 by mhammond, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
pre-install-script.patch mhammond, 2004-02-07 23:53 patch as described
Messages (4)
msg45360 - (view) Author: Mark Hammond (mhammond) * (Python committer) Date: 2004-02-07 23:53
Hi Thomas :)  Sorry, but a few changes rolled up in one.

install.c: support for a 'pre-install-script', run
before anything has been installed.  Provides a
'message_box' module function for use by either the
pre-install or post-install scripts.

bdist_wininst.py: support for pre-install script.  Typo
(build->built), fixes so that --target-version can
still work, even when the distribution has extension
modules - in this case, we insist on --skip-build, as
we still can't actually build other versions.
msg45361 - (view) Author: Thomas Heller (theller) * (Python committer) Date: 2004-02-20 11:26
Logged In: YES 
user_id=11105

I've fixed the typo in the 2.3 release branch.

Do you think the other things should be in 2.3 as well?
msg45362 - (view) Author: Thomas Heller (theller) * (Python committer) Date: 2004-02-20 11:41
Logged In: YES 
user_id=11105

Mark, unfortunately I cannot apply the patch.  The CVS
version of install.c which is used by Python nowadays is in
the Python CVS tree - in
dist\src\PC\bdist_wininst\install.c, no longer that one in
the separate distutils CVS module.

Can you create a new patch, or shall I manually apply the
changes?
msg45363 - (view) Author: Thomas Heller (theller) * (Python committer) Date: 2004-02-20 14:43
Logged In: YES 
user_id=11105

I have manually made the changes in your patch.

I can build and run the installer for pywin32 with it.

Checking in for 2.4.
History
Date User Action Args
2022-04-11 14:56:02adminsetgithub: 39910
2004-02-07 23:53:27mhammondcreate