This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: markupbase misses comments (bug 736659)
Type: Stage:
Components: Library (Lib) Versions:
process
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: fdrake Nosy List: fdrake, jimjjewett
Priority: normal Keywords: patch

Created on 2004-02-20 20:58 by jimjjewett, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
markuppatch.txt jimjjewett, 2004-02-20 20:59
Messages (3)
msg45407 - (view) Author: Jim Jewett (jimjjewett) Date: 2004-02-20 20:58
markupbase.ParserBase().parse_declaration calls 
parse_comment if the text starts with "<!--" -- except 
that if the text starts with "<!-" it has already 
shortcircuited, thinking it has a short buffer.

Change is just a single character - to ask if the first *2* 
characters are "" or "-" instead of the first *1*.
msg45408 - (view) Author: Fred Drake (fdrake) (Python committer) Date: 2004-09-09 03:54
Logged In: YES 
user_id=3066

markupbase is currently undocumented and (probably) should
not be used directly.  The concrete subclasses of
markupbase.ParserBase (sgmllib.SGMLParser and
HTMLParser.HTMLParser) handle comments properly because
comments are not handled using parse_declaration().

I've added tests for the concrete subclasses to make sure
they do the right thing with comments crossing buffer
bonudaries.

Since markupbase is currently undocumented and not complete
by itself, I think the right thing to do is clarify in the
markupbase source that it isn't intended to be used directly.
msg45409 - (view) Author: Fred Drake (fdrake) (Python committer) Date: 2005-08-23 04:09
Logged In: YES 
user_id=3066

Closed by docstring change in Lib/markupbase.py revisions
1.11, 1.10.4.1.
History
Date User Action Args
2022-04-11 14:56:02adminsetgithub: 39964
2004-02-20 20:58:44jimjjewettcreate