➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: urllib2.parse_http_list bugfix 735248
Type: Stage:
Components: Library (Lib) Versions:
process
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: Nosy List: georg.brandl, jimjjewett, titus
Priority: normal Keywords: patch

Created on 2004-02-20 23:34 by jimjjewett, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
urllib2diff.txt jimjjewett, 2004-02-20 23:39
urllib2patch.txt jimjjewett, 2004-02-20 23:40
Messages (4)
msg45410 - (view) Author: Jim Jewett (jimjjewett) Date: 2004-02-20 23:34 
With unquoted elements, the current code forgets to 
throw away the already processed portion.

>>> urllib2.parse_http_list('a,b,c')
['a', 'a,b', 'a,b,c']

The current code does not handle escaped characters.
>>> len(urllib2.parse_http_list(r'"a"\,"b","c"'))
3

This patch replaces parse_http_list and adds a helper 
function.  I also added docstricts for these cases, and a 
few others (which the current code does get right, but 
which are not ...)
msg45411 - (view) Author: Jim Jewett (jimjjewett) Date: 2004-02-20 23:42 
Logged In: YES 
user_id=764593

The cutoff portion just said that the current code did get the 
remaining tests right, but I might have missed them myself if I 
hadn't been looking at the old code when I wrote it.  So I 
want them there for the next person.
msg45412 - (view) Author: Titus Brown (titus) Date: 2004-12-19 08:26 
Logged In: YES 
user_id=23486

Fix works against latest CVS. As noted it does fix bug 735248 and also 
works on quoted strings.

I made a context diff against the current CVS.  It's at

http://issola.caltech.edu/~t/transfer/patch-901480-parse.diff

This diff fixes a docstring & also allows direct application to the current 
CVS.

Recommend application.
msg45413 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2005-08-24 22:22 
Logged In: YES 
user_id=1188172

Wrt the fixing of bug #735248, this is unnecessary.
History
Date User Action Args
2022-04-11 14:56:02adminsetgithub: 39965
2004-02-20 23:34:54jimjjewettcreate