This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: New module cookielib
Type: Stage:
Components: Library (Lib) Versions: Python 2.4
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: jjlee, loewis
Priority: normal Keywords: patch

Created on 2004-05-30 23:39 by jjlee, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
NEWS.patch jjlee, 2004-05-30 23:39
libcookie.tex.patch jjlee, 2004-05-30 23:41
test_urllib2.py.patch jjlee, 2004-05-30 23:42
liburllib2.tex.patch jjlee, 2004-05-30 23:43
urllib2.py.patch jjlee, 2004-05-30 23:44
test_urllib2.py.patch_v2 jjlee, 2004-05-31 17:06
liburllib2.tex.patch_v2 jjlee, 2004-05-31 17:06
urllib2.py.patch_v2 jjlee, 2004-05-31 17:09
cookielib_logging_fix.patch jjlee, 2004-05-31 23:21
Messages (7)
msg46098 - (view) Author: John J Lee (jjlee) Date: 2004-05-30 23:39
cookielib itself is here:

http://codespeak.net/svn/user/jjlee/wwwsearch/ClientCookie/branch/python-2.4_candidate/

All I'm uploading here are patches to the various other
files in Python  that are affected.


Remaining issues:

-The .unverifiable and .origin_req_host attributes I've
added to urllib2.Request are a bit ugly (yet another
bit of HTTP-specific state).  But I guess it's too late
to start having subclasses for specific protocol schemes.

-Implementation wart: ._now attributes.

-test_urllib2.py depends on test_cookielib.py.  What's
the right way to fix this?

-Thread synchronization needs checking by someone with
more of a clue about this: I have great confidence that
it IS currently broken, since I've never tested it.

-Update magic string in LWPCookieJar, if Gisle agrees
(I'm waiting for a reply).
msg46099 - (view) Author: John J Lee (jjlee) Date: 2004-05-31 11:07
Logged In: YES 
user_id=261020

The files that should be copied from the subversion
repository are:

_LWPCookieJar.py
_MozillaCookieJar.py
cookielib.py
test/test_cookielib.py
msg46100 - (view) Author: John J Lee (jjlee) Date: 2004-05-31 14:20
Logged In: YES 
user_id=261020

Martin, in case you are just about to apply this: I've
finally stopped dithering about the first 'remaining issue'
above (unverifiable and origin_req_host), and am just about
to update liburllib2.tex.patch, urllib2.py.patch and
test_urllib2.py.patch (and cookielib itself).
msg46101 - (view) Author: John J Lee (jjlee) Date: 2004-05-31 17:09
Logged In: YES 
user_id=261020

OK, done.
msg46102 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2004-05-31 18:23
Logged In: YES 
user_id=21627

Thanks for the patch. Applied as

lib.tex 1.226
libcookie.tex 1.12
libcookielib.tex 1.1
liburllib2.tex 1.18
whatsnew24.tex 1.49
_LWPCookieJar.py 1.1
_MozillaCookieJar.py 1.1
cookielib.py 1.1
urllib2.py 1.67
test_cookielib.py 1.1
test_urllib2.py 1.13
NEWS 1.978
msg46103 - (view) Author: John J Lee (jjlee) Date: 2004-05-31 23:21
Logged In: YES 
user_id=261020

Here's a fix for the noisy unit tests.
msg46104 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2004-06-01 04:38
Logged In: YES 
user_id=21627

Thanks, committed as 1.2. Please create new patches in the
future if you wish to make further changes. If you find they
get no attention, give them priority 6 and assign them to me.
History
Date User Action Args
2022-04-11 14:56:04adminsetgithub: 40311
2004-05-30 23:39:13jjleecreate