This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Cleanup generator/eval_frame exposure
Type: Stage:
Components: Interpreter Core Versions: Python 2.4
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: loewis Nosy List: jwpye, loewis, rhettinger
Priority: normal Keywords: patch

Created on 2004-06-04 12:58 by jwpye, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
cleanup.diff jwpye, 2004-06-04 12:58
Messages (3)
msg46117 - (view) Author: James William Pye (jwpye) Date: 2004-06-04 12:58
Hopefully get this cleanup in before 2.4..

. Include genobject.h in Python.h to save embedders an
AC check to identify its existance(allowing a simple
#ifndef Py_GENOBJECT_H)
. Follow up my own recommendation to just reference
eval_frame directly by exposing it(change references in
ceval.c and genobject.c accordingly).
. Update headers accordingly; reference frameobject in
genobject.h and ceval.h as struct _frame * like others
do to avoid including frameobject.h

Rename PyEval_EvaluateFrame to PyEval_EvalFrame to be
consistent with PyEval_EvalCode[Ex] in eval.h.

Hopefully it isnt too late to change this before 2.4,
sorry for not having it in the first patch.. :-(

Changes files:

genobject.c
genobject.h
ceval.c
ceval.h
Python.h
msg46118 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2004-06-15 11:33
Logged In: YES 
user_id=80475

Martin, I believe this patches your checkin.
msg46119 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2004-06-27 15:43
Logged In: YES 
user_id=21627

Thanks for the patch. Committed as

Python.h 2.64
ceval.h 2.52
genobject.h 2.2
genobject.c 1.3
ceval.c 2.407
History
Date User Action Args
2022-04-11 14:56:04adminsetgithub: 40344
2004-06-04 12:58:31jwpyecreate