➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: testtar.tar is partially insane
Type: Stage:
Components: Extension Modules Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: tim.peters Nosy List: lars.gustaebel, tim.peters
Priority: normal Keywords:

Created on 2004-07-13 18:00 by tim.peters, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (3)
msg21552 - (view) Author: Tim Peters (tim.peters) * (Python committer) Date: 2004-07-13 18:00 
The test file testtar.tar is a binary file, but contains 
(seemingly by accident) CVS keywords, like $Date$ and 
$Revision$.  As a result, if Python is checked out with -
kk (don't expand keywords), test_tarfile fails.  I'm not 
clear on exactly why.

Binary files shouldn't have CVS keywords inside them, 
and tests shouldn't care whether keywords are 
expanded anyway.
msg21553 - (view) Author: Lars Gustäbel (lars.gustaebel) * (Python committer) Date: 2004-07-21 13:52 
Logged In: YES 
user_id=642936

When I created testtar.tar I used a copy of pep-0000.txt as
dummy data, and that has CVS keywords in it. The problem is,
that -kk substitutes the keywords, although testtar.tar was
checked in with -kb. I blame CVS's rotten handling of binary
files for that one.

I opened a patch #995225 with a new testtar.tar that has no
keywords.
msg21554 - (view) Author: Tim Peters (tim.peters) * (Python committer) Date: 2004-07-22 01:06 
Logged In: YES 
user_id=31435

Patch 995225 has been checked in, so closing as Fixed.  
FWIW, I blame CVS too.
History
Date User Action Args
2022-04-11 14:56:05adminsetgithub: 40552
2004-07-13 18:00:39tim.peterscreate