This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: audioop extension should be enabled on 64-bit archs
Type: Stage:
Components: Build Versions: Python 2.4
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: doko, loewis
Priority: normal Keywords: patch

Created on 2004-07-18 07:16 by doko, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
setup.diff doko, 2004-07-18 07:16
Messages (2)
msg46387 - (view) Author: Matthias Klose (doko) * (Python committer) Date: 2004-07-18 07:16
[ forwarded from http://bugs.debian.org/260051 ]

Patch submitter writes:

The audioop extension is disabled on 64-bit
architectures, but the reasoning used in the
justification is flawed; it checks for whether "maxint"
is a 64-bit value, which it is, but audioop explicitly
uses a 32-bit integer type everywhere.
 
The attached patch re-enables this extension; tested on
alpha-linux, works fine.
 
The imageop and rgbimg extensions may also be usable on
64-bit platforms, but I haven't tested them. 
msg46388 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2004-07-19 16:52
Logged In: YES 
user_id=21627

Thanks for the patch, applied as

setup.py 1.194
Setup.dist 1.46

Notice that the test for MAXINT is not a justification, but
the test itself to check for 64-bitness. The claim that the
module does not work on 64-bit systems originates from 1.65
of Modules/Setup.in. Unfortunately, Guido's claim that it
doesn't work back then is about as convincing as the Steve
Langasek's claim that it does work now.

If we find it does break, we should document more clearly
(or, perhaps, even fix it...)
History
Date User Action Args
2022-04-11 14:56:05adminsetgithub: 40589
2004-07-18 07:16:07dokocreate