This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Unicode in distutils.core.setup()
Type: Stage:
Components: Distutils Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: theller Nosy List: doerwalter, theller
Priority: normal Keywords: patch

Created on 2004-07-19 17:09 by doerwalter, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
bdist_wininst.diff doerwalter, 2004-07-19 17:09
Messages (5)
msg46393 - (view) Author: Walter Dörwald (doerwalter) * (Python committer) Date: 2004-07-19 17:09
distutils.core.setup() should support Unicode objects for 
the author argument and others and properly show them 
in the Windows installer (currently repr() is used one the 
value, which leads to strange results. Attached is 
Thomas Heller's patch for that.
msg46394 - (view) Author: Walter Dörwald (doerwalter) * (Python committer) Date: 2004-07-19 17:14
Logged In: YES 
user_id=89016

Testing this patch doesn't work for me, but this seems to be 
more a problem of the build process than of this patch. 
Updating to CVS head on Windows, compiling the pythoncore 
and python target in Visual C++ .net Standard (without 
applying the patch) and running a setup script with this 
python.exe gives me the following:
\Python-current\dist\src\PCbuild\python setup.py bdist --
formats=wininst
running bdist
running bdist_wininst
running build
running build_py
Traceback (most recent call last):
  File "setup.py", line 50, in ?
    package_dir={"ll": ""}
  File "D:\Python-current\dist\src\lib\distutils\core.py", line 
150, in setup
    dist.run_commands()
  File "D:\Python-current\dist\src\lib\distutils\dist.py", line 
951, in run_commands
    self.run_command(cmd)
  File "D:\Python-current\dist\src\lib\distutils\dist.py", line 
971, in run_command
    cmd_obj.run()
  File "D:\Python-
current\dist\src\lib\distutils\command\bdist.py", line 146, in 
run
    self.run_command(cmd_name)
  File "D:\Python-current\dist\src\lib\distutils\cmd.py", line 
333, in run_command
    self.distribution.run_command(command)
  File "D:\Python-current\dist\src\lib\distutils\dist.py", line 
971, in run_command
    cmd_obj.run()
  File "D:\Python-
current\dist\src\lib\distutils\command\bdist_wininst.py", line 
127, in run
    assert self.skip_build, "Should have already checked this"
AssertionError: Should have already checked this
msg46395 - (view) Author: Thomas Heller (theller) * (Python committer) Date: 2004-07-20 12:40
Logged In: YES 
user_id=11105

Walter, I cannot reproduce this behaviour, even with the
ansistyle setup script.  And you're the only one reporting this.

Do you have anything special (setup.cfg is the only on that
comes to mind)?  Do you get the same from the 'python
setup.py bdist_wininst' command?

How does python-2.4a1 from python.org behave for you?
msg46396 - (view) Author: Walter Dörwald (doerwalter) * (Python committer) Date: 2004-07-21 17:16
Logged In: YES 
user_id=89016

Now it's working perfectly with Python-2.4a1 (the CVS 
version complains about the missing zlib module). It works 
both with "setup.py bdist --formats=wininst" and "setup.py 
bdist_wininst". Maybe my Windows box required a few more 
reboots after the Visual C++ installation? The resulting 
Windows installer looks good, so I guess you can check this in.
msg46397 - (view) Author: Thomas Heller (theller) * (Python committer) Date: 2004-07-23 19:44
Logged In: YES 
user_id=11105

Fixed in bdist_wininst, rev 1.52.
History
Date User Action Args
2022-04-11 14:56:05adminsetgithub: 40596
2004-07-19 17:09:40doerwaltercreate